Re: Proposed GUC Variable

From: Larry Rosenman <ler(at)lerctr(dot)org>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>, Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposed GUC Variable
Date: 2002-08-27 21:17:07
Message-ID: 1030483028.410.38.camel@lerlaptop.iadfw.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Tue, 2002-08-27 at 16:14, Bruce Momjian wrote:
> Larry Rosenman wrote:
> > > But we should have some default to print some of the query, because
> > > right now we print none of it. I am not saying it is perfect, but it is
> > > better than what we have, and is a reasonable default.
> > On an error, you may not be able to reproduce it. Why not print the
> > whole query to the log?
> >
> > I don't see a reason for truncating it at 80 chars.
> >
> > IMHO, of course.
>
> Because every typo query, every syntax error of a user in psql would
> appear in your logs. That seems excessive. Already the ERROR line
> appears in the logs. Do we want to see their bad query too?
>
> My concern is that long queries could easily bulk up the logs to the
> point where the actual important log messages would be lost in the fog.
Hmm. I think the 80 should be a GUC variable (and also settable from
SQL SET as well), and the 80 should probably be higher.

And, maybe send the full query at a different Syslog(3) level.

--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 972-414-9812 E-Mail: ler(at)lerctr(dot)org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2002-08-27 21:19:42 Re: [HACKERS] pg_attribute.attisinherited ?
Previous Message Bruce Momjian 2002-08-27 21:16:31 Re: SET SCHEMA?

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2002-08-27 21:19:42 Re: [HACKERS] pg_attribute.attisinherited ?
Previous Message Bruce Momjian 2002-08-27 21:14:43 Re: Proposed GUC Variable