Re: pg_dump large file support

On Thu, 2002-08-15 at 11:41, Oliver Elphick wrote:
> I've implemented large file support for pg_dump, in what I hope is a
> portable fashion. Please review the attached patch.

> Index: src/bin/pg_dump/Makefile
> ===================================================================
> RCS file: /projects/cvsroot/pgsql-server/src/bin/pg_dump/Makefile,v
> retrieving revision 1.36
> diff -u -r1.36 Makefile
> --- src/bin/pg_dump/Makefile 2002/07/27 20:10:05 1.36
> +++ src/bin/pg_dump/Makefile 2002/08/15 10:31:53
> @@ -18,6 +18,8 @@
>
> override CPPFLAGS := -I$(libpq_srcdir) $(CPPFLAGS)
>
> +CFLAGS += -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
> +

I just realised this is the wrong place to put this definition, since it
will act unconditonally and attempt to compile large file support even
where it is not available. This too ought to come from autoconf, I
think.

--
Oliver Elphick Oliver(dot)Elphick(at)lfix(dot)co(dot)uk
Isle of Wight, UK
http://www.lfix.co.uk/oliver
GPG: 1024D/3E1D0C1C: CA12 09E0 E8D5 8870 5839 932A 614D 4C34 3E1D 0C1C
========================================
"Praying always with all prayer and supplication in the
Spirit, and watching thereunto with all perseverance
and supplication for all saints." Ephesians 6:18