Re: COPYable logs status

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: COPYable logs status
Date: 2007-06-11 15:20:15
Message-ID: 10294.1181575215@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> I'll try to get a patch out for just the stderr case, which should be
> back-patchable, then adjust the CSVlog patch to use it.

Sounds like a plan.

> I'm thinking of handling the partial lines with a small dynahash of
> StringInfo buffers, which get discarded whenever we don't have a partial
> line for the PID.

A hashtable might be overkill --- based on reports so far, it's unlikely
you'd have more than two or three messages being received concurrently,
so a simple list or array might be quicker to search.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2007-06-11 17:03:05 ecpg compile error in regression tests
Previous Message Andrew Dunstan 2007-06-11 15:01:42 Re: What's with the StartDb:2 failures on skylark?

Browse pgsql-patches by date

  From Date Subject
Next Message Pavel Stehule 2007-06-11 15:45:14 Re: WIP: updatable cursors in plpgsql
Previous Message Tom Lane 2007-06-11 15:11:59 Re: WIP: updatable cursors in plpgsql