| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: pgbench: Allow the transaction log file prefix to be changed. |
| Date: | 2016-11-10 03:08:06 |
| Message-ID: | 10286.1478747286@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Wed, Nov 9, 2016 at 4:51 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Perhaps the "logpath" buffer that the filename is constructed in
>> needs to be made bigger. 64 bytes was obviously enough with the
>> old pattern, but it's not with the new.
> Oops, yes, that seems like a good idea. How about 64 -> MAXPGPATH?
If we want to stick with the fixed-size-buffer-on-stack approach,
that would be the thing to use. psprintf is another possibility,
though that would add a malloc/free cycle.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-11-10 03:12:10 | Re: Re: [COMMITTERS] pgsql: pgbench: Allow the transaction log file prefix to be changed. |
| Previous Message | Robert Haas | 2016-11-10 00:03:40 | Re: [COMMITTERS] pgsql: pgbench: Allow the transaction log file prefix to be changed. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-11-10 03:12:10 | Re: Re: [COMMITTERS] pgsql: pgbench: Allow the transaction log file prefix to be changed. |
| Previous Message | Amit Langote | 2016-11-10 02:58:09 | Re: Declarative partitioning - another take |