Re: Keepalives win32

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Pavel Golub <pavel(at)gf(dot)microolap(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Keepalives win32
Date: 2010-06-30 14:57:44
Message-ID: 10283.1277909864@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> But you previously stated that this code was ignoring the registry
>> values. So doesn't "system defaults" boil down to whatever Windows'
>> wired-in defaults are?

> The order is Windows wired-in-defaults -> registry values -> what app chooses.

> And yes, we *are* ignoring whatever the user has put in the registry,

How does that statement square with your follow-on example?

> Assume the user had reconfigured his default in the registry to 1 hour.

> If the user makes no config change at all, that means it will run with
> 1 hour for idle and 1 second for interval.

> If we now set tcp_interval to 10 seconds (to change the default), we
> will now also change his idle value back to the system default, so he
> will get 2 hours for idle and 10 seconds for interval. Thus, we are
> ignoring the changes he made globally on his system.

With the code as you have it, yes, but if we do it as I'm suggesting,
that doesn't happen --- the effective value of the other parameter
doesn't change.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-06-30 15:02:08 Re: Check constraints on non-immutable keys
Previous Message Bruce Momjian 2010-06-30 14:56:20 Re: Keepalives win32