| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Add TAP tests for pg_dump |
| Date: | 2016-05-06 20:31:12 |
| Message-ID: | 10280.1462566672@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Stephen Frost wrote:
>> I'm guessing the right answer here is to just add test_pg_dump to that
>> list.
> I don't like this solution, because it means pg_dump will get little
> testing on Windows.
No, that's incorrect: @contrib_excludes stops the MSVC stuff from trying
to *build* in that directory, which is fine because there's nothing to
build. It doesn't prevent running the test case. See eg.
http://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=thrips&dt=2016-05-06%2015%3A37%3A27&stg=testmodules-install-check-C
where the test_extensions test does get run even though it's in
@contrib_excludes.
In any case, reverting the patch would mean no Windows testing, so
your argument doesn't seem to have much force even if it were true?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2016-05-06 20:35:55 | Re: pgsql: Add TAP tests for pg_dump |
| Previous Message | Tom Lane | 2016-05-06 20:21:16 | pgsql: More small 9.6 release note improvements. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-05-06 20:34:53 | Re: Reviewing freeze map code |
| Previous Message | Alvaro Herrera | 2016-05-06 20:31:02 | Re: Initial release notes created for 9.6 |