| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | pgsql-committers(at)postgresql(dot)org, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Record full paths of programs sought by "configure". |
| Date: | 2017-08-07 19:36:38 |
| Message-ID: | 10269.1502134598@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> On 08/07/2017 03:21 PM, Tom Lane wrote:
>> I'm confused. AFAIK, that commit did not change which "prove" would
>> be used --- at least not unless you change PATH between configure and
>> make. It only changed how specifically that program would be named in
>> Makefile.global. Please clarify how that broke anything.
> That's exactly what we do. See
> <https://github.com/PGBuildFarm/client-code/blob/master/run_build.pl> at
> line 1649.
My goodness, that's ugly. Is it really better than injecting
"PROVE=prove"? (I'd suggest saying that to configure, not make,
so that the configure log bears some resemblance to what you
want done.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2017-08-07 19:58:02 | Re: pgsql: Record full paths of programs sought by "configure". |
| Previous Message | Andrew Dunstan | 2017-08-07 19:31:50 | Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure". |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2017-08-07 19:58:02 | Re: pgsql: Record full paths of programs sought by "configure". |
| Previous Message | Robert Haas | 2017-08-07 19:34:53 | Re: expanding inheritance in partition bound order |