| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Coding in WalSndWaitForWal |
| Date: | 2020-01-09 19:56:05 |
| Message-ID: | 10254.1578599765@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> In modern times, we define pg_attribute_noreturn() like this:
> /* GCC, Sunpro and XLC support aligned, packed and noreturn */
> #if defined(__GNUC__) || defined(__SUNPRO_C) || defined(__IBMC__)
> #define pg_attribute_noreturn() __attribute__((noreturn))
> #define HAVE_PG_ATTRIBUTE_NORETURN 1
> #else
> #define pg_attribute_noreturn()
> #endif
> I suppose this will cause warnings in compilers other than those, but
> I'm not sure if we care. What about MSVC for example?
Yeah, the lack of coverage for MSVC seems like the main reason not
to assume this works "everywhere of interest".
> With the attached patch, everything compiles cleanly in my setup, no
> warnings, but then it's GCC.
Meh ... I'm not really convinced that any of those changes are
improvements. Particularly not the removals of switch-case breaks.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2020-01-09 20:00:28 | Re: Removing pg_pltemplate and creating "trustable" extensions |
| Previous Message | Robert Haas | 2020-01-09 19:55:43 | Re: our checks for read-only queries are not great |