Re: Counting lines correctly in psql help displays

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Greg Stark <stark(at)mit(dot)edu>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Counting lines correctly in psql help displays
Date: 2015-09-05 20:50:16
Message-ID: 10180.1441486216@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greg Stark <stark(at)mit(dot)edu> writes:
> But that said, here's a tricksy patch that triggers an assertion
> failure if the expected_lines is wrong. I intended it to trigger in
> the regression tests so it only checks if the pager is actually off.
> It wouldn't be hard to make it always check though.

Hmm ... that would put a premium on the linecount always being exactly
right (for all callers, not just the help functions). Not sure that
I want to buy into that --- it would require more complexity in the
callers than is there now, for sure.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-09-05 23:39:06 Re: Outdated documentation for PageHeaderData
Previous Message Julien Rouhaud 2015-09-05 20:11:14 Outdated documentation for PageHeaderData