| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com> |
| Cc: | Julien Tachoires <julmon(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: SUBTRANS: Minimizing calls to SubTransSetParent() |
| Date: | 2022-11-29 18:30:02 |
| Message-ID: | 1017593.1669746602@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com> writes:
> New version of patch, now just a one-line patch!
Of course, there's all the documentation and comments that you falsified.
Also, what of the SubTransSetParent call in ProcessTwoPhaseBuffer?
(The one in ProcArrayApplyXidAssignment is actually okay, though the
comment making excuses for it no longer is.)
Also, if we're going to go over to a one-level structure in pg_subtrans,
we really ought to simplify the code in subtrans.c accordingly, and
get rid of the extra lookup currently done for the top parent's parent.
I still wonder whether we'll regret losing information about the
subtransaction tree structure, as discussed in the other thread [1].
That seems like the main barrier to proceeding with this.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2022-11-29 18:31:49 | Re: Support logical replication of DDLs |
| Previous Message | Dimos Stamatakis | 2022-11-29 18:21:54 | Re: Fix for visibility check on 14.5 fails on tpcc with high concurrency |