Re: Basic DOMAIN Support

On Thu, 2002-03-07 at 17:18, Rod Taylor wrote:
> I've corrected the problem with shell type creation, so regression
> tests work properly now (with the exception of NOTICE -> INFO /
> WARNING changes). I have issues with timestamp tests, but the
> failures match current cvs so I'll assume I've not contributed to
> them.

All the regression tests (including the timestamp related ones) pass for
me with current CVS, without the patch applied. With the patch applied,
the "privileges" test fails.

> The shift / reduce problem was fixed by simply removing the ability to
> make types with complex defaults (reverted back to old simple
> methods).

I still see a shift / reduce conflict in gram.y

> I don't see any of the compile warnings other were receiving though.

make[3]: Entering directory `/home/nconway/pgsql/src/backend/catalog'
gcc-3.0 -O2 -Wall -Wmissing-prototypes -Wmissing-declarations
-I../../../src/include -c -o heap.o heap.c
heap.c: In function `cookDefault':
heap.c:1904: warning: implicit declaration of function `getBaseType'

make[3]: Entering directory `/home/nconway/pgsql/src/backend/parser'
gcc-3.0 -O2 -Wall -Wmissing-prototypes -Wmissing-declarations
-I../../../src/include -c -o analyze.o analyze.c
gcc-3.0 -O2 -Wall -Wmissing-prototypes -Wmissing-declarations
-I../../../src/include -c -o gram.o gram.c
gram.y: In function `yyparse':
gram.y:3228: warning: assignment from incompatible pointer type
gram.y:3232: warning: assignment from incompatible pointer type

gcc-3.0 -O2 -Wall -Wmissing-prototypes -Wmissing-declarations
-I../../../src/include -c -o parse_coerce.o parse_coerce.c
parse_coerce.c:637:1: warning: no newline at end of file

make[3]: Entering directory `/home/nconway/pgsql/src/backend/nodes'
gcc-3.0 -O2 -Wall -Wmissing-prototypes -Wmissing-declarations
-I../../../src/include -c -o copyfuncs.o copyfuncs.c
copyfuncs.c:2232: warning: `_copyCreateDomainStmt' defined but not used

make[4]: Entering directory
`/home/nconway/pgsql/src/backend/optimizer/prep'
gcc-3.0 -O2 -Wall -Wmissing-prototypes -Wmissing-declarations
-I../../../../src/include -c -o preptlist.o preptlist.c
preptlist.c: In function `build_column_default':
preptlist.c:358: warning: unused variable `typedefault'

Also:

src/backend/catalog/heap.c: spelling: "typically for domiains"

Cheers,

Neil

--
Neil Conway <neilconway(at)rogers(dot)com>
PGP Key ID: DB3C29FC