pg_dump: use ALTER TABLE for PKs

From: Neil Conway <nconway(at)klamath(dot)dyndns(dot)org>
To: pgsql-hackers(at)postgresql(dot)org
Subject: pg_dump: use ALTER TABLE for PKs
Date: 2002-02-19 02:26:05
Message-ID: 1014085565.372.8.camel@jiro
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I've attached a patch which enhances pg_dump to use ALTER TABLE when
defining the primary keys of a table (instead of including this
information in the table definition).

This follows a suggestion by Christopher Kings-Lynne (good idea!).

The patch is pretty simple, partly because the code was already there,
just commented out ;-) I fixed a typo and added some comments.

Bruce suggested that this should get some code review, since a bug in
pg_dump would be bad news. Any comments would be welcome.

Cheers,

Neil

--
Neil Conway <neilconway(at)rogers(dot)com>
PGP Key ID: DB3C29FC

Attachment Content-Type Size
pg_dump_pk.patch text/x-patch 2.9 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Neil Conway 2002-02-19 02:28:26 Re: [HACKERS] Selectively compile psql
Previous Message Samik Raychaudhuri 2002-02-19 02:05:04 Selectively compile psql