Re: pgsql: Fix behavior of ~> (cube, int) operator

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix behavior of ~> (cube, int) operator
Date: 2018-01-21 20:20:42
Message-ID: 10131.1516566042@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Teodor Sigaev <teodor(at)sigaev(dot)ru> writes:
> Fix behavior of ~> (cube, int) operator

This patch has caused Coverity to complain, correctly AFAICS, about
dead code in cube_coord_llur in the back branches:

1628 /* Inverse value if needed */
1629 if (inverse)
>>> CID 1463943: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "result = -result;".
1630 result = -result;
1631
1632 PG_RETURN_FLOAT8(result);

Seems to be due to sloppy division of changes between f50c80dbb (which
was not back-patched) and 563a053bd. Please fix.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2018-01-22 09:18:52 pgsql: Fix docs typo
Previous Message Magnus Hagander 2018-01-21 14:45:32 pgsql: Support huge pages on Windows