| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Peter Geoghegan <pg(at)heroku(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Satoshi Nagayasu <snaga(at)uptime(dot)jp>, Josh Kupershmidt <schmiddy(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_filedump 9.3: checksums (and a few other fixes) |
| Date: | 2013-07-08 23:59:06 |
| Message-ID: | 10107.1373327946@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Well, Tom opined in
> http://www.postgresql.org/message-id/23249.1370878717@sss.pgh.pa.us that
> the current patch is okay. I have a mild opinion that it should instead
> print only SHR_LOCK when both bits are set, and one of the others when
> only one of them is set. But I don't have a strong opinion about this,
> and since Tom disagrees with me, feel free to exercise your own (Jeff's)
> judgement.
FWIW, I think that's exactly what I did in the preliminary 9.3 patch
that I committed to pg_filedump a few weeks ago. Could you take a look
at what's there now and see if that's what you meant?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2013-07-09 00:35:47 | [9.4 CF] Free VMs for Reviewers & Testers |
| Previous Message | Michael Paquier | 2013-07-08 23:00:52 | Re: XLogInsert scaling, revisited |