Re: ExecSetupTransitionCaptureState not declared in nodeModifyTable.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ExecSetupTransitionCaptureState not declared in nodeModifyTable.c
Date: 2023-12-06 02:02:20
Message-ID: 1006679.1701828140@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

jian he <jian(dot)universality(at)gmail(dot)com> writes:
> static void
> ExecSetupTransitionCaptureState(ModifyTableState *mtstate, EState *estate);

> not declared in src/backend/executor/nodeModifyTable.c.
> do we need to add the declaration?

Not if the compiler's not complaining about it. We don't have a
policy requiring all static functions to be forward-declared.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Sutou Kouhei 2023-12-06 02:44:47 Re: Make COPY format extendable: Extract COPY TO format implementations
Previous Message jian he 2023-12-06 01:50:02 ExecSetupTransitionCaptureState not declared in nodeModifyTable.c