| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | John Naylor <jcnaylor(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Documentation for bootstrap data conversion |
| Date: | 2018-04-19 21:16:41 |
| Message-ID: | 10044.1524172601@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
John Naylor <jcnaylor(at)gmail(dot)com> writes:
> I've attached a patch that mostly touches boilerplate comments in the
> headers and data files. I couldn't resist editing some comments for
> clarity and consistency.
Pushed, along with a little bit of extra tweaking to fix random
discrepancies in the header comments.
> Not in the patch, but I'll also mention this stanza in tablecmds.c
> around line 4370, where the comment doesn't quite match the code and
> error message:
Yeah. That's a translatable error message though, so I'm hesitant
to mess with it just for neatnik-ism. Doubt it's worth the translators'
time to change it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-04-19 21:23:07 | Re: Repeated crashes in GENERATED ... AS IDENTITY tests |
| Previous Message | Alexander Korotkov | 2018-04-19 21:00:11 | Re: Corrupted btree index on HEAD because of covering indexes |