John Naylor <john(dot)naylor(at)enterprisedb(dot)com> writes:
> On Fri, Jul 30, 2021 at 7:53 AM PG Bug reporting form <
> noreply(at)postgresql(dot)org> wrote:
>> - if (l < -INT_MAX || l > INT_MAX)
>> + if (l < (-INT_MAX - 1) || l > INT_MAX)
> Yeah, that looks like it should be INT_MIN instead. I'll see about making
> that happen. Thanks for the report!
The whole stanza perhaps ought to be within
#if SIZEOF_LONG > SIZEOF_INT
otherwise some compilers will bleat about useless tests.
(I looked at PGTYPESnumeric_to_long and it seems like it will do
the right thing for 32-bit long, assuming strtol does.)
regards, tom lane