| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [COMMITTERS] pgsql: Reserve the shared memory region during backend startup on |
| Date: | 2009-07-27 14:14:52 |
| Message-ID: | 10009.1248704092@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> To fix that we'd just have to turn those functions all into returning
> boolean and log with LOG instead. AFAIK, we've had zero reports of
> this actually happening, so I'm not sure it's worth redesigning.
> Thoughts?
I'm not really insisting on a redesign. I'm talking about the places
where the code author appears not to have understood that ERROR means
FATAL, because the code keeps plugging on after it anyway. As far as
I can see, using ERROR at lines 3630, 3657, 3674, and 3693 is just
plain bogus, and changing to LOG there requires no other fixing.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-07-28 02:56:31 | pgsql: Add system catalog columns pg_constraint.conindid and |
| Previous Message | Magnus Hagander | 2009-07-27 09:01:44 | Re: [COMMITTERS] pgsql: Reserve the shared memory region during backend startup on |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-07-27 14:20:18 | Re: [RFC] new digest datatypes, or generic fixed-len hex types? |
| Previous Message | Kevin Grittner | 2009-07-27 14:09:56 | Re: When is a record NULL? |