| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: increasing the default WAL segment size |
| Date: | 2017-02-16 05:33:46 |
| Message-ID: | 10007.1487223226@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2017-02-15 22:46:38 -0300, Alvaro Herrera wrote:
>> Now that we've renamed "xlog" to "wal" in user-facing elements, I think
>> we should strive to use the name "wal" internally too in new code, not
>> "xlog" anymore. This patch introduces several variables, macros,
>> functions that ought to change names now -- XLogSegmentOffset should be
>> WALSegmentOffset for example. (I expect that as we touch code over
>> time, the use of "xlog" will decrease, though not fully disappear).
> I think this will just decrease the consistency in xlog.c (note the
> name) et al.
It's also going to make back-patching bug fixes in the area a real
nightmare. Let's not change the code more than necessary to implement
the desired user-facing behavior.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2017-02-16 05:38:04 | Re: patch: function xmltable |
| Previous Message | Seki, Eiji | 2017-02-16 05:24:25 | Re: Proposal: GetOldestXminExtend for ignoring arbitrary vacuum flags |