From: | "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com> |
---|---|
To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | RE: Parallel Inserts in CREATE TABLE AS |
Date: | 2020-11-26 02:17:21 |
Message-ID: | 0fd2e6cd829f4ee9be18d0053c09fc7d@G08CNEXMBPEKD05.g08.fujitsu.local |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
I have an issue about the following code:
econtext = node->ps.ps_ExprContext;
ResetExprContext(econtext);
+ if (ISCTAS(node->ps.intoclause))
+ {
+ ExecParallelInsertInCTAS(node);
+ return NULL;
+ }
/* If no projection is required, we're done. */
if (node->ps.ps_ProjInfo == NULL)
return slot;
/*
* Form the result tuple using ExecProject(), and return it.
*/
econtext->ecxt_outertuple = slot;
return ExecProject(node->ps.ps_ProjInfo);
It seems the projection will be skipped.
Is this because projection is not required in this case ?
(I'm not very familiar with where the projection will be.)
If projection is not required here, shall we add some comments here?
Best regards,
houzj
From | Date | Subject | |
---|---|---|---|
Next Message | Craig Ringer | 2020-11-26 02:19:00 | Re: [PATCH] LWLock self-deadlock detection |
Previous Message | Bharath Rupireddy | 2020-11-26 01:54:01 | Re: Multi Inserts in CREATE TABLE AS - revived patch |