| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Zhihong Yu <zyu(at)yugabyte(dot)com>, "Andrey V(dot) Lepikhov" <a(dot)lepikhov(at)postgrespro(dot)ru>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: POC: postgres_fdw insert batching |
| Date: | 2021-01-21 02:36:31 |
| Message-ID: | 0fc809f6-7c3c-6d06-7ea3-f10765dfdf08@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/21/21 3:09 AM, tsunakawa(dot)takay(at)fujitsu(dot)com wrote:
> From: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
>> Right, that's pretty much what I ended up doing (without the CMD_INSERT
>> check it'd add batching info to explain for updates too, for example).
>> I'll do a bit more testing on the attached patch, but I think that's the right fix to
>> push.
>
> Thanks to the outer check for operation == CMD_INSERT, the inner one became unnecessary.
>
Right. I've pushed the fix, hopefully buildfarm will get happy again.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2021-01-21 02:47:06 | Re: [PATCH 1/1] Initial mach based shared memory support. |
| Previous Message | Zhihong Yu | 2021-01-21 02:29:48 | Re: Parallel INSERT (INTO ... SELECT ...) |