| From: | Andrei Lepikhov <lepihov(at)gmail(dot)com> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Subject: | Re: Reordering DISTINCT keys to match input path's pathkeys |
| Date: | 2024-10-28 09:15:09 |
| Message-ID: | 0fc11a92-f6e4-4d8c-b882-91283ef54bce@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 6/7/24 16:46, Richard Guo wrote:
> On Mon, Feb 5, 2024 at 11:18 AM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
>> cfbot reminds that this patch does not apply any more. So I've rebased
>> it on master, and also adjusted the test cases a bit.
>
> This patch does not apply any more, so here is a new rebase, with some
> tweaks to the comments.
This patch needs a minor rebase again.
After skimming the code, I want to say that it looks good. But maybe to
avoid one more *_reordering GUC - it would be better to cover all path
key reorderings under a single GUC.
--
regards, Andrei Lepikhov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2024-10-28 09:16:17 | Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails |
| Previous Message | Alexander Lakhin | 2024-10-28 09:00:00 | Re: Better error reporting from extension scripts (Was: Extend ALTER OPERATOR) |