| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench |
| Date: | 2021-06-25 02:12:44 |
| Message-ID: | 0f49303e-7784-b3ee-200b-cbf67be2eb9e@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 6/24/21 9:53 PM, Michael Paquier wrote:
> On Thu, Jun 24, 2021 at 09:36:53PM -0400, Andrew Dunstan wrote:
>> That's not really an equivalent test. I'm taking a look
> Thanks!
There's a whole lot wrong with this code. To start with, why is that
unchecked eval there. And why is it reading in log files on its own
instead of using TestLib::slurp_file, which, among other things,
normalizes line endings? There's a very good chance that this latter is
the issue. It only affects msys which is why you didn't see an issue on
MSVC. And also, why does it carefully unlink the log files so that any
trace of what's gone wrong is deleted?
Based on the little I've seen this file needs a serious code review.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2021-06-25 02:26:18 | Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench |
| Previous Message | Michael Paquier | 2021-06-25 01:53:59 | Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2021-06-25 02:26:18 | Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench |
| Previous Message | Bruce Momjian | 2021-06-25 01:56:42 | Re: PG 14 release notes, first draft |