Re: Refreshing subscription relation state inside a transaction block

From: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Refreshing subscription relation state inside a transaction block
Date: 2017-06-13 07:53:23
Message-ID: 0ec51cc7-0bca-0d86-1394-3fc77c158200@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 13/06/17 09:06, Masahiko Sawada wrote:
> Hi,
>
> The commit ddd7b22b225ae41d16ceb218b387645cb9becfdc makes table sync
> workers stop when subscription relation entry is removed. It doesn't
> work fine inside transaction block. I think we should disallow to use
> the following subscription DDLs inside a transaction block. Attached
> patch.
>

Can you be more specific than "It doesn't work fine inside transaction
block", what do you expect to happen and what actually happens?

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alex Kliukin 2017-06-13 08:58:42 Re: [HACKERS] Why restore_command is called for existing files in pg_xlog?
Previous Message Thomas Munro 2017-06-13 07:52:04 Re: RTE_NAMEDTUPLESTORE, enrtuples and comments