Re: Make all Perl warnings fatal

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Make all Perl warnings fatal
Date: 2023-12-29 19:27:31
Message-ID: 0e7c7c7c-4a67-4550-a36d-a9fcd8aa8489@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 22.12.23 22:33, Peter Eisentraut wrote:
> On 12.09.23 07:42, Peter Eisentraut wrote:
>> On 10.08.23 07:58, Peter Eisentraut wrote:
>>> There are also a couple of issues in the MSVC legacy build system
>>> that would need to be tightened up in order to survive with fatal
>>> Perl warnings.  Obviously, there is a question whether it's worth
>>> spending any time on that anymore.
>>
>> It looks like there are no principled objections to the overall idea
>> here, but given this dependency on the MSVC build system removal, I'm
>> going to set this patch to Returned with feedback for now.
>
> Now that that is done, here is an updated patch for this.
>
> I found one more bug in the Perl code because of this, a fix for which
> is included here.
>
> With this fix, this passes all the CI tests on all platforms.

committed

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-12-29 19:36:25 Re: Add new protocol message to change GUCs for usage with future protocol-only GUCs
Previous Message Pavel Stehule 2023-12-29 19:15:50 Re: Schema variables - new implementation for Postgres 15