Re: BUG #15212: Default values in partition tables don't work as expected and allow NOT NULL violation

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #15212: Default values in partition tables don't work as expected and allow NOT NULL violation
Date: 2018-11-09 04:56:36
Message-ID: 0e1b2dde-263a-3399-fe83-affa6381e6b1@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 2018/11/09 1:38, Alvaro Herrera wrote:
> On 2018-Nov-09, Amit Langote wrote:
>
>> On Fri, Nov 9, 2018 at 1:03 AM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>>> On 2018-Nov-07, Amit Langote wrote:
>
>>> Hmm, I'm thinking perhaps we shouldn't backpatch this part. It's
>>> obviously a bug, but we might break somebody's working apps. Therefore
>>> I think I'd rather leave it out of the current bugfix and commit
>>> separately.
>>
>> Okay, that may be fine because nothing wrong is happening by silently
>> ignoring the partition's specified collation.
>
> Actually, how about we reduce the message to a WARNING in released
> branches, and ERROR in master? Broken applications would continue to
> work, but users might become aware that there might be a problem.

That might work too. Would you like me to create and post patches like
that for 10 and 11 branches?

Thanks,
Amit

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Amit Langote 2018-11-09 05:04:45 Re: BUG #15212: Default values in partition tables don't work as expected and allow NOT NULL violation
Previous Message Thomas Munro 2018-11-09 01:25:08 Re: BUG #15492: pg_cancel_backend(pg_backend_pid()) returns true sporadically

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2018-11-09 04:58:36 Re: Resetting PGPROC atomics in ProcessInit()
Previous Message Clarence Ho 2018-11-09 04:51:52 Re: Strange corruption in psql output on mereswine