| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Should we use MemSet or {0} for struct initialization? |
| Date: | 2023-09-19 09:37:30 |
| Message-ID: | 0db914aa-cb4c-d399-ce55-5acab65e34c7@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 31.08.23 10:32, Richard Guo wrote:
> While working on a bug in expandRecordVariable() I noticed that in the
> switch statement for case RTE_SUBQUERY we initialize struct ParseState
> with {0} while for case RTE_CTE we do that with MemSet. I understand
> that there is nothing wrong with this, just cannot get away with the
> inconsistency inside the same function (sorry for the nitpicking).
>
> Do we have a preference for how to initialize structures? From 9fd45870
> it seems that we prefer to {0}. So here is a trivial patch doing that.
> And with a rough scan the MemSet calls in pg_stat_get_backend_subxact()
> can also be replaced with {0}, so include that in the patch too.
The first part (parse_target.c) was already addressed by e0e492e5a9. I
have applied the second part (pgstatfuncs.c).
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthias van de Meent | 2023-09-19 10:07:07 | Re: XLog size reductions: Reduced XLog record header size for PG17 |
| Previous Message | bt23nguyent | 2023-09-19 09:21:59 | Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set |