Re: pgsql: Save calculated transitionSpace in Agg node.

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Davis <jdavis(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Save calculated transitionSpace in Agg node.
Date: 2020-02-27 23:28:47
Message-ID: 0d6f3e77dc0c02ee4ab44dff3c8b15ac8f06f99a.camel@j-davis.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, 2020-02-27 at 14:56 -0500, Tom Lane wrote:
> Jeff Davis <jdavis(at)postgresql(dot)org> writes:
> > Save calculated transitionSpace in Agg node.
>
> Surely this patch is a few bricks shy of a load. Don't you need
> copyfuncs/readfuncs/outfuncs support, for starters?

Sorry, I will fix it.

I was looking at whether changes to copyfuncs (etc.) should also cause
a catversion bump, and it seems inconsistent. Commit 9ce77d75 does, but
6ef77cf4 does not. Any particular rules around that? Not terribly
important as the catversion was just bumped anyway; just curious.

Regards,
Jeff Davis

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-02-27 23:36:36 Re: pgsql: Save calculated transitionSpace in Agg node.
Previous Message Alvaro Herrera 2020-02-27 20:27:41 pgsql: Catversion bump for b9b408c48724