From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
---|---|
To: | bt21tanigaway <bt21tanigaway(at)oss(dot)nttdata(dot)com>, Shinya11(dot)Kato(at)nttdata(dot)com |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented |
Date: | 2021-10-04 04:59:19 |
Message-ID: | 0d484953-8bfc-9e88-2dfd-3cb1cb4a3e59@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2021/10/04 11:17, bt21tanigaway wrote:
>>> else if (Matches("LOCK", MatchAny, "IN", "ACCESS|ROW") ||
>>> - Matches("LOCK", "TABLE", MatchAny, "IN", "ACCESS|ROW"))
>>> + Matches("LOCK", "TABLE", MatchAny, "IN", "ACCESS|ROW") ||
>>> + Matches("LOCK", "ONLY", MatchAny, "IN", "ACCESS|ROW") ||
>>> + Matches("LOCK", "TABLE", "ONLY", MatchAny, "IN", "ACCESS|ROW"))
>> I think this code is redundant, so I change following.
>> ---
>> else if (HeadMatches("LOCK") && TailMatches("IN", "ACCESS|ROW"))
>> ---
>> I created the patch, and attached it. Do you think?
> Thank you for update!
> I think that your code is more concise than mine.
> There seems to be no problem.
The patch looks good to me, too. I applied cosmetic changes to it.
Attached is the updated version of the patch. Barring any objection,
I will commit it.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Attachment | Content-Type | Size |
---|---|---|
fix_tab_completion_of_lock_fujii.patch | text/plain | 3.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2021-10-04 05:04:22 | Re: pgsql: Document XLOG_INCLUDE_XID a little better |
Previous Message | Amit Kapila | 2021-10-04 04:26:29 | Re: pgsql: Document XLOG_INCLUDE_XID a little better |