Re: Removal of plaintext password type references

On 05/15/2017 07:03 AM, Noah Misch wrote:
> On Thu, May 11, 2017 at 10:08:30AM +0900, Michael Paquier wrote:
>> On Wed, May 10, 2017 at 10:22 PM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
>>> On Wed, May 10, 2017 at 10:01 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>>> Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
>>>>> Also note that changing the signature check_password_hook_type would
>>>>> break any external modules that use the hook. Removing
>>>>> PASSWORD_TYPE_PLAINTEXT will do that too, because any password hook
>>>>> function would use that constant (see e.g. contrib/passwordcheck). If we
>>>>> were to change the signature, I'd actually like to simplify it by
>>>>> removing the password_type parameter altogether. The hook function can
>>>>> call get_password_type() on the password itself to get the same
>>>>> information. But it's not worth changing the API and breaking external
>>>>> modules for that.
>>>
>>> Ahah. I just had the same thought before reading this message.
>>
>> And attached is a patch to do that. I am all for this one to get a
>> more simple interface in place.
>
> [Action required within three days. This is a generic notification.]

I still don't think this worth it to change the hook function's
signature for this. Even though it's not a big deal for external modules
to adapt, it's not zero effort either. And it's not that much nicer to us.

- Heikki