From: | David Steele <david(at)pgmasters(dot)net> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: non-exclusive backup cleanup is mildly broken |
Date: | 2019-12-13 23:50:25 |
Message-ID: | 0c930fd0-ce3a-5ba7-a3a6-26c036f08db3@pgmasters.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 12/13/19 3:56 AM, Magnus Hagander wrote:
> On Fri, Dec 13, 2019 at 9:00 AM Michael Paquier <michael(at)paquier(dot)xyz
>
> I think that's a bad idea to put a restriction of this kind. There
> are large consumers of 2PC, and everybody needs backups.
>
>
> You misunderstood me. I certainly didn't mean that people who use 2PC
> shouldn't be able to use proper backups -- that would be *terrible*.
>
> I meant disallowing pg_start_backup() in a session that had a prepared
> transaction, and disallowing preparing a transaction in a session with
> an ongoing backup. They would still work perfectly fine in *other*
> parallel sessions.
+1. I think it is reasonable to expect pg_start/stop_backup() to be
performed in its own session without prepared transactions.
+more if this concession keeps other aspects of the code simpler.
--
-David
david(at)pgmasters(dot)net
From | Date | Subject | |
---|---|---|---|
Next Message | Jeremy Schneider | 2019-12-14 00:13:35 | Re: logical decoding bug: segfault in ReorderBufferToastReplace() |
Previous Message | Daniel Gustafsson | 2019-12-13 23:32:30 | Re: xlog.c variable pointlessly global |