| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Redefining inet_net_ntop |
| Date: | 2018-01-26 05:10:24 |
| Message-ID: | 0c5db733-cbea-bf6b-1d3c-46db325e8612@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/25/18 22:24, Craig Ringer wrote:
> port.h declares inet_net_ntop and we always compile our own
> from port/inet_net_ntop.c .
>
> But it's part of -lresolv on Linux, and more importantly, it's declared
> in <inet/arpa.h>.
>
> Should we be using our own if the OS has it? I'm thinking of adding a
> test to configure and omitting our own version if configure finds it.
ISTR that ours is hacked to produce specific output. Do the regression
tests still pass if you use the one from the OS?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tsunakawa, Takayuki | 2018-01-26 05:22:29 | RE: Temporary tables prevent autovacuum, leading to XID wraparound |
| Previous Message | Thomas Munro | 2018-01-26 04:19:16 | Re: WIP: Covering + unique indexes. |