Re: BUG #17355: Server crashes on ExecReScanForeignScan in postgres_fdw when accessing foreign partition

From: Marina Polyakova <m(dot)polyakova(at)postgrespro(dot)ru>
To: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #17355: Server crashes on ExecReScanForeignScan in postgres_fdw when accessing foreign partition
Date: 2022-02-03 10:37:55
Message-ID: 0c5d710abcd92dc474b04ce802055a9f@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 2022-02-03 09:38, Etsuro Fujita wrote:
> I think it would be better to create a separate patch so that we test
> not only this but other EvalPlanQual stuff such as ForeignRecheck, so
> I applied the proposed patch to HEAD as well.
>
> Thanks!
>
> Best regards,
> Etsuro Fujita

Hello everyone in this thread!

Looks like gcc 11.2.0 is now reporting a warning in the branches
master/REL_14_STABLE, e.g. see CI
https://github.com/postgres/postgres/runs/5047720839:

[06:30:18.201] nodeForeignscan.c: In function ‘ForeignNext’:
[06:30:18.201] nodeForeignscan.c:47:13: error: unused variable ‘estate’
[-Werror=unused-variable]
[06:30:18.201] 47 | EState *estate = node->ss.ps.state;
[06:30:18.201] | ^~~~~~

Please could you fix it? E.g. like in the attached patch - the following
commands work for me with it:

$ ./configure && COPT=-Werror make world-bin

--
Marina Polyakova
Postgres Professional: http://www.postgrespro.com

Attachment Content-Type Size
diff_fix_ForeignNext_warning.patch text/x-diff 661 bytes

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2022-02-03 13:26:03 BUG #17393: Delete database after recovery with point-in-time is still missing datafiles
Previous Message Улаев Александр Сергеевич 2022-02-03 10:29:18 RE: Re:BUG #17392: archiver process exited with exit code 2 was unexpectedly cause for immediate shutdown request