Re: [PATCH] pgweb: Add SEARCH_DSN to example settings.py

From: Célestin Matte <celestin(dot)matte(at)cmatte(dot)me>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL WWW <pgsql-www(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] pgweb: Add SEARCH_DSN to example settings.py
Date: 2022-01-19 14:30:50
Message-ID: 0c0f0cff-513a-e2e5-8ff7-a8f1463e364d@cmatte.me
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

Hi,

I'm reviewing the patches I sent a few months ago and this short one seems to have been left mid-discussion.

> I think having a default like in this patch is better. Otherwise it could randomly connect to a database with the same name as the user for example, which might actually happen in dev scenarios. So if we want it empty we'd also need to add code to check if it's set or not before trying to use it - seems easier to set the default and have it fail :)

I guess it's OK as-is, then?

--
Célestin Matte

In response to

Responses

Browse pgsql-www by date

  From Date Subject
Next Message Magnus Hagander 2022-01-19 22:26:00 Re: [PATCH] Fix typo in an unsubscribe-related message
Previous Message Célestin Matte 2022-01-19 10:35:06 Re: [PATCH] pglister: Add example script to import from mailman