Re: Announcing Release 6 of PostgreSQL Buildfarm client

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: buildfarm-members(at)postgresql(dot)org
Subject: Re: Announcing Release 6 of PostgreSQL Buildfarm client
Date: 2018-01-04 20:39:41
Message-ID: 0b3217e4-b275-ba4d-0571-30b4aae237e0@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: buildfarm-members pgsql-hackers

On 01/04/2018 12:51 PM, Tom Lane wrote:
> I wrote:
>> which means I get mail every time the cron script runs. Needless
>> to say, that will not do. Previously, mail only showed up when
>> there was a git checkout failure. How do I get back to the
>> old behavior?
> Diff'ing the v5 and v6 releases soon provided the answer: for some
> reason v6 is forcing the verbose switch on. I hope that was
> unintentional? Anyway, I'm happy again after applying this patch:
>
> --- PGBuild/Options.pm~ 2018-01-04 08:38:29.000000000 -0500
> +++ PGBuild/Options.pm 2018-01-04 12:40:14.000000000 -0500
> @@ -78,8 +78,6 @@
> GetOptions(%standard_options, @_)
> || die "bad command line";
>
> - # override GetOptions default for :i
> - $verbose = 1 if (defined($verbose) && $verbose==0);
> $verbose ||= 0; # stop complaints about undefined var in numeric comparison
> }
>

This should fix it:
<https://raw.githubusercontent.com/PGBuildFarm/client-code/5c71fb6ba1be83db6aca45e718b4a541b0b89f4c/PGBuild/Options.pm>

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse buildfarm-members by date

  From Date Subject
Next Message Andrew Dunstan 2018-01-05 20:18:54 Buildfarm Client Bugfix Release 6.1
Previous Message Andrew Dunstan 2018-01-04 18:37:18 Re: Announcing Release 6 of PostgreSQL Buildfarm client

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2018-01-04 20:41:39 Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256
Previous Message Peter Eisentraut 2018-01-04 20:36:41 pgsql: Implement channel binding tls-server-end-point for SCRAM