Re: Improve a few appendStringInfo calls new to v18

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Improve a few appendStringInfo calls new to v18
Date: 2025-04-10 08:24:36
Message-ID: 0aec6cce-edc9-4fb5-bd18-187ff299fbcb@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 10/04/2025 06:51, David Rowley wrote:
> Looks like v18 has grown a few appendStringInfo misusages, e.g. using
> appendStringInfo() when no formatting is needed or just using format
> "%s" instead of using appendStringInfoString().
>
> I've attached a couple of patches. The 0001 is just my method for
> finding these, not for commit.

Clever!

> 0002 contains the fixes to commit.
>
> Any objections to doing this soonish? Or in a few weeks?

Sure, let's do it. Why would we wait?

--
Heikki Linnakangas
Neon (https://neon.tech)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kirill Reshke 2025-04-10 08:25:00 Re: speedup COPY TO for partitioned table.
Previous Message Thomas Munro 2025-04-10 08:16:52 Re: 64 bit numbers vs format strings