From: | Tatsuro Yamada <tatsuro(dot)yamada(dot)tf(at)nttcom(dot)co(dot)jp> |
---|---|
To: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: list of extended statistics on psql |
Date: | 2020-08-24 07:41:32 |
Message-ID: | 0ab933af-ecb5-b1f7-b79f-6a56b563f6a5@nttcom.co.jp_1 |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi!
>> +1 good idea
>
> +1 that's a good idea. Please add it to the next commitfest!
Thanks!
> You have a typo:
>
> + if (pset.sversion < 10000)
> + {
> + char sverbuf[32];
> +
> + pg_log_error("The server (version %s) does not support
> extended statistics.",
> + formatPGVersionNumber(pset.sversion, false,
> + sverbuf, sizeof(sverbuf)));
> + return true;
> + }
>
> the version test is missing a 0, the feature looks otherwise ok.
Ouch, I fixed on the attached patch.
The new patch includes:
- Fix the version number check (10000 -> 100000)
- Fix query to get extended stats info for sort order
- Add handling [Pattern] e.g \dz stts*
- Add document and regression test for \dz
> How about using \dX rather than \dz?
Thanks for your suggestion!
I'll replace it if I got consensus. :-D
Thanks,
Tatsuro Yamada
Attachment | Content-Type | Size |
---|---|---|
add_list_extended_stats_for_psql_poc2.patch | text/plain | 7.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2020-08-24 07:58:34 | Re: Documentation patch for backup manifests in protocol.sgml |
Previous Message | John Naylor | 2020-08-24 07:28:17 | Re: factorial function/phase out postfix operators? |