Re: Track the amount of time waiting due to cost_delay

From: "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Track the amount of time waiting due to cost_delay
Date: 2024-06-11 18:19:23
Message-ID: 0EA474B6-BF88-49AE-82CA-C1A9A3C17727@amazon.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> I'm not convinced that reporting the number of waits is useful. If we
> were going to report a possibly-inaccurate amount of actual waiting,
> then also reporting the number of waits might make it easier to figure
> out when the possibly-inaccurate number was in fact inaccurate. But I
> think it's way better to report an accurate amount of actual waiting,
> and then I'm not sure what we gain by also reporting the number of
> waits.

I think including the number of times vacuum went into sleep
will help paint a full picture of the effect of tuning the vacuum_cost_delay
and vacuum_cost_limit for the user, even if we are reporting accurate
amounts of actual sleeping.

This is particularly true for autovacuum in which the cost limit is spread
across all autovacuum workers, and knowing how many times autovacuum
went to sleep will be useful along with the total time spent sleeping.

Regards,

Sami

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2024-06-11 18:47:29 Re: Track the amount of time waiting due to cost_delay
Previous Message Jan Wieck 2024-06-11 17:26:20 Re: Track the amount of time waiting due to cost_delay