Re: REINDEX backend filtering

> On Mar 14, 2021, at 8:33 PM, Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
>
> <v7-0001-Add-a-new-OUTDATED-filtering-facility-for-REINDEX.patch><v7-0002-Add-a-outdated-option-to-reindexdb.patch>

In the docs, 0001, "Fow now, the only dependency handled currently",

"Fow now" is misspelled, and "For now" seems redundant when used with "currently".

In the docs, 0002, "For now only dependency on collations are supported."

"dependency" is singular, "are" is conjugated for plural.

In the docs, 0002, you forgot to update doc/src/sgml/ref/reindexdb.sgml with the documentation for the --outdated switch.

In the tests, you check that REINDEX (OUTDATED) doesn't do anything crazy, but you are not really testing the functionality so far as I can see, as you don't have any tests which cause the collation to be outdated. Am I right about that? I wonder if you could modify DefineCollation. In addition to the providers "icu" and "libc" that it currently accepts, I wonder if it might accept "test" or similar, and then you could create a test in src/test/modules that compiles a "test" provider, creates a database with indexes dependent on something from that provider, stops the database, updates the test collation, ...?

—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company