Re: pgsql: Remove the adminpack contrib extension

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Remove the adminpack contrib extension
Date: 2024-03-04 16:11:47
Message-ID: 0D569522-B87D-4178-A15E-9751905614EF@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> On 4 Mar 2024, at 16:27, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2024-Mar-04, Daniel Gustafsson wrote:
>
>> The pg_upgrade Xversion test on crake failed on this, I'm trying to reproduce
>> the cross-version test locally to verify the below diff but it's right now
>> failing on an unrelated thing.
>
> What unrelated thing?

I was trying to get the crossversion tests to work with make check, but was
only able to get them running properly with make installcheck, will investigate
that further. So unrelated to the specific failure at hand, not unrelated to
crossversion testing.

> I suggest to try to initdb the old version with
> the current REL_12_STABLE branch tip, because IIRC there are changes
> that cause the pg_upgrade test to fail.

I see that my fix didn't solve it for 11 and 9.x on crake and drongo, will
rebuild more old trees and test to find the correct fix.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2024-03-04 16:31:47 pgsql: Further fix pg_upgrade crossversion test for adminpack.
Previous Message Alvaro Herrera 2024-03-04 15:27:13 Re: pgsql: Remove the adminpack contrib extension