| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: BUG #17212: pg_amcheck fails on checking temporary relations |
| Date: | 2021-10-11 18:26:24 |
| Message-ID: | 0B7DA7A4-2872-485B-BFDD-BF8E9BB07B26@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
> On Oct 11, 2021, at 11:12 AM, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
>
> What's the problem with just having pg_amcheck pass through the notice
> to the user, without it affecting anything else? Why should a simple
> notice message need to affect its return code, or anything else?
That's fine by me, but I was under the impression that people wanted the extraneous noise removed. Since pg_amcheck can know the command is going to draw a "you can't check that right now" type message, one might argue that it is drawing these notices for no particular benefit. Somebody could quite reasonably complain about this on a hot standby with millions of unlogged relations. Actual ERROR messages might get lost in all the noise.
It's true that these NOTICEs do not change the return code. I was thinking about the ERRORs we get on failed lock acquisition, but that is unrelated.
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2021-10-11 18:26:29 | Re: BUG #17212: pg_amcheck fails on checking temporary relations |
| Previous Message | Peter Geoghegan | 2021-10-11 18:12:07 | Re: BUG #17212: pg_amcheck fails on checking temporary relations |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2021-10-11 18:26:29 | Re: BUG #17212: pg_amcheck fails on checking temporary relations |
| Previous Message | Andres Freund | 2021-10-11 18:25:35 | Re: Corruption with IMMUTABLE functions in index expression. |