| From: | Dent John <denty(at)QQdd(dot)eu> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Verite <daniel(at)manitou-mail(dot)org>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Roman Pekar <roma(dot)pekar(at)gmail(dot)com> |
| Subject: | Re: [WIP] UNNEST(REFCURSOR): allowing SELECT to consume data from a REFCURSOR |
| Date: | 2020-02-22 10:38:30 |
| Message-ID: | 0B00672A-B3EF-4FA3-9CBE-ADFEF7068181@QQdd.eu |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 18 Feb 2020, at 03:03, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>
> From the trivialities department, I see a bunch of warnings about
> local declaration placement (we're still using C90 rules for those by
> project policy):
>
> refcursor.c:138:3: error: ISO C90 forbids mixed declarations and code
> [-Werror=declaration-after-statement]
> MemoryContext oldcontext =
> MemoryContextSwitchTo(funcctx->multi_call_memory_ctx);
> ^
Thanks for pointing that out.
I have updated the patch.
denty.
| Attachment | Content-Type | Size |
|---|---|---|
| unnest-refcursor-v6a.patch | application/octet-stream | 32.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2020-02-22 11:13:19 | Re: reindex concurrently and two toast indexes |
| Previous Message | Julien Rouhaud | 2020-02-22 07:09:24 | Re: reindex concurrently and two toast indexes |