| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Hubert Zhang <zhubert(at)vmware(dot)com>, tsunakawa(dot)takay(at)fujitsu(dot)com, pgsql-hackers(at)postgresql(dot)org, Andreas Seltenreich <seltenreich(at)gmx(dot)de>, Bruce Momjian <bruce(at)momjian(dot)us> |
| Subject: | Re: Multiple hosts in connection string failed to failover in non-hot standby mode |
| Date: | 2021-05-17 11:06:51 |
| Message-ID: | 0AA4785E-AE5B-44B0-A4FE-2E7003BE2FC5@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 11 May 2021, at 09:29, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> FWIW, I think that the case of getting some information about any
> failed connections while a connection has been successfully made
> within the scope of the connection string parameters provided by the
> user is rather thin, and I really feel that this is going to cause
> more pain to users than this is worth it. So my vote would be to
> clean up conn->errorMessage after a successful connection.
Agreed, given how conservative we typically are with backwards compatibility it
seems a too thin benefit to warrant potential breakage.
My vote would too be to restore the behavior by clearing conn->errorMessage.
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pengchengliu | 2021-05-17 11:18:05 | RE: Parallel scan with SubTransGetTopmostTransaction assert coredump |
| Previous Message | Amit Kapila | 2021-05-17 10:53:18 | Re: Inaccurate error message when set fdw batch_size to 0 |