From: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> |
---|---|
To: | 'Michael Paquier' <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | RE: Temporary tables prevent autovacuum, leading to XID wraparound |
Date: | 2018-02-07 00:51:55 |
Message-ID: | 0A3221C70F24FB45833433255569204D1F8B1515@G01JPEXMBYT05 |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
From: Michael Paquier [mailto:michael(dot)paquier(at)gmail(dot)com]
> > postmaster deletes temporary relation files at startup by calling
> > RemovePgTempFiles() regardless of whether it's in recovery. It
> > doesn't call that function during auto restart after a crash when
> > restart_after_crash is on.
>
> The comment on top of RemovePgTempFiles() states the following:
> * NOTE: we could, but don't, call this during a post-backend-crash restart
> * cycle. The argument for not doing it is that someone might want to
> examine
> * the temp files for debugging purposes. This does however mean that
> * OpenTemporaryFile had better allow for collision with an existing temp
> * file name.
Yes, I saw that comment. postmaster keeps orphaned temp relation files only after a crash when restart_after_crash is on.
> Nice to hear that. Please note that I did not check your patch, so I cannot
> conclude on its correctness in details.
I thought so. Don't mind.
Regards
Takayuki Tsunakawa
From | Date | Subject | |
---|---|---|---|
Next Message | Kyotaro HORIGUCHI | 2018-02-07 01:34:58 | Re: [HACKERS] More stats about skipped vacuums |
Previous Message | Michael Paquier | 2018-02-07 00:43:40 | Re: Temporary tables prevent autovacuum, leading to XID wraparound |