| From: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> |
|---|---|
| To: | 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Supporting huge pages on Windows |
| Date: | 2017-03-31 02:35:10 |
| Message-ID: | 0A3221C70F24FB45833433255569204D1F6BE14D@G01JPEXMBYT05 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
From: Amit Kapila [mailto:amit(dot)kapila16(at)gmail(dot)com]
> The latest patch looks good to me apart from one Debug message, so I have
> marked it as Ready For Committer.
Thank you so much!
> + ereport(DEBUG1,
> + (errmsg("disabling huge pages")));
>
> I think this should be similar to what we display in sysv_shmem.c as below:
>
> elog(DEBUG1, "mmap(%zu) with MAP_HUGETLB failed, huge pages disabled: %m",
> allocsize);
I understood you suggested this to make the reason clear for disabling huge pages. OK, done as follows.
+ elog(DEBUG1, "CreateFileMapping(%llu) with SEC_LARGE_PAGES failed "
+ "due to insufficient large pages, huge pages disabled",
+ size);
I hope this will be committed soon.
Regards
Takayuki Tsunakawa
| Attachment | Content-Type | Size |
|---|---|---|
| win_large_pages_v10.patch | application/octet-stream | 8.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vitaly Burovoy | 2017-03-31 02:39:30 | Re: sequence data type |
| Previous Message | Dmitry Dolgov | 2017-03-31 02:32:41 | Re: [PATCH] Generic type subscripting |