From: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> |
---|---|
To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | [RFC] Should "SHOW huge_pages" display the effective value "off" when the huge page is unavailable? |
Date: | 2017-02-06 07:01:31 |
Message-ID: | 0A3221C70F24FB45833433255569204D1F699DEE@G01JPEXMBYT05 |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello, all
Could you give me your opinions on whether the SHOW command should display the effective value or the specified value for huge_pages? During the review of "Supporting huge_pages on Windows", which is now shifted to CommitFest 2017-3, Magnus gave me a comment that the huge_page variable should retain the value "try" when the huge page is not available on the machine and the server falls back to huge_page=off. The Linux version does so.
I don't have a strong opinion on that, but I think a bit that it would be better to reflect the effective setting, i.e. SHOW displays huge_pages as off, not try. Otherwise, the user cannot know whether the huge page setting is effective.
One parameter that behaves similarly is wal_buffers. When wal_buffers is set to -1 (default), "SHOW wal_buffers" displays the actual size, not -1. But I didn't find any other parameters like this.
Regards
Takayuki Tsunakawa
From | Date | Subject | |
---|---|---|---|
Next Message | Tsunakawa, Takayuki | 2017-02-06 07:44:21 | Re: [RFC] Should I embed or parameterize syscall/Win32 function names from error messages? |
Previous Message | Boris Muratshin | 2017-02-06 07:01:09 | Re: 3D Z-curve spatial index |