From: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> |
---|---|
To: | 'Robert Haas' <robertmhaas(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [RFC] Should we fix postmaster to avoid slow shutdown? |
Date: | 2016-11-22 05:43:39 |
Message-ID: | 0A3221C70F24FB45833433255569204D1F65677C@G01JPEXMBYT05 |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
From: Robert Haas [mailto:robertmhaas(at)gmail(dot)com]
> So there are two questions here:
>
> 1. Should we try to avoid having the stats collector write a stats file
> during an immediate shutdown? The file will be removed anyway during crash
> recovery, so writing it is pointless. I think you are right that 9.4's
> solution here is not perfect, because of the 5 second delay, and also because
> if the stats collector is stuck inside the kernel trying to write to the
> OS, it may be in a non-interruptible wait state where even SIGKILL has no
> immediate effect. Anyway, it's stupid even from a performance point of
> view to waste time writing a file that we're just going to nuke.
>
> 2. Should we close listen sockets sooner during an immediate shutdown?
> I agree with Tom and Peter that this isn't a good idea. People expect
> the sockets not to go away until the end - e.g. they use
> PQping() to test the server status, or they connect just to see what error
> they get - and the fact that a client application could hypothetically
> generate such a relentless stream of connection attempts that the dead-end
> backends thereby created slow down shutdown is not in my mind a sufficient
> reason to change the behavior.
>
> So I think 001 should proceed and 002 should be rejected.
I'm happy with this conclusion, since I think 1 was the cause of slow shutdown, and 2 is just a hypothesis to pursue the completeness. And I can understand the concern about PQping().
Regards
Takayuki Tsunakawa
From | Date | Subject | |
---|---|---|---|
Next Message | Mithun Cy | 2016-11-22 06:04:07 | Re: [PATCH] pgpassfile connection option |
Previous Message | Tsunakawa, Takayuki | 2016-11-22 04:58:34 | Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled |