Re: pgsql: Add tests for libpq gssencmode and sslmode options

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add tests for libpq gssencmode and sslmode options
Date: 2024-04-10 14:48:11
Message-ID: 09d4bf5d-d0fa-4c66-a1d7-5ec757609646@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 08.04.24 01:50, Heikki Linnakangas wrote:
> Add tests for libpq gssencmode and sslmode options

Why aren't these tests at
src/interfaces/libpq/t/nnn_negotiate_encryption.pl ?

> Test all combinations of gssencmode, sslmode, whether the server
> supports SSL and/or GSSAPI encryption, and whether they are accepted
> by pg_hba.conf. This is in preparation for refactoring that code in
> libpq, and for adding a new option for "direct SSL" connections, which
> adds another dimension to the logic.
>
> If we add even more options in the future, testing all combinations
> will become unwieldy and we'll need to rethink this, but for now an
> exhaustive test is nice.
>
> Author: Heikki Linnakangas, Matthias van de Meent
> Reviewed-by: Jacob Champion
> Discussion: https://www.postgresql.org/message-id/a3af4070-3556-461d-aec8-a8d794f94894@iki.fi
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/1169920ff77025550718b90a5cafc6849875f43f
>
> Modified Files
> --------------
> .cirrus.tasks.yml | 2 +-
> src/test/libpq_encryption/Makefile | 25 +
> src/test/libpq_encryption/README | 31 ++
> src/test/libpq_encryption/meson.build | 18 +
> .../libpq_encryption/t/001_negotiate_encryption.pl | 548 +++++++++++++++++++++
> src/test/meson.build | 1 +
> 6 files changed, 624 insertions(+), 1 deletion(-)
>

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2024-04-10 15:54:57 Re: pgsql: Add tests for libpq gssencmode and sslmode options
Previous Message Daniel Gustafsson 2024-04-10 12:06:26 pgsql: Doc: Update ulinks to RFC documents to avoid redirect

Browse pgsql-hackers by date

  From Date Subject
Next Message Parag Paul 2024-04-10 14:55:16 Re: Issue with the PRNG used by Postgres
Previous Message Robert Haas 2024-04-10 14:43:02 Re: Issue with the PRNG used by Postgres