| From: | "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com> |
|---|---|
| To: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, "Amit Langote" <amitlangote09(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)fujitsu(dot)com> |
| Subject: | RE: Determine parallel-safety of partition relations for Inserts |
| Date: | 2021-02-01 05:02:18 |
| Message-ID: | 09b79792101548a3a83e8e57722b3f74@G08CNEXMBPEKD05.g08.fujitsu.local |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi greg,
Thanks for the review !
> Personally, I think a table's "parallel_dml" option should be ON by default.
> It's annoying to have to separately enable it for each and every table being
> used, when I think the need to turn it selectively OFF should be fairly
> rare.
Yes, I agreed.
Changed.
> And I'm not sure that "parallel_dml" is the best name for the table option
> - because it sort of implies parallel dml WILL be used - but that isn't
> true, it depends on other factors too.
> So I think (to be consistent with other table option naming) it would have
> to be something like "parallel_dml_enabled".
Agreed.
Changed to parallel_dml_enabled.
Attatching v2 patch which addressed the comments above.
Some further refactor:
Introducing a new function is_parallel_possible_for_modify() which decide whether to do safety check.
IMO, It seems more readable to extract all the check that we can do before the safety-check and put them
in the new function.
Please consider it for further review.
Best regards,
houzj
| Attachment | Content-Type | Size |
|---|---|---|
| v2_0003-reloption-parallel_dml-src.patch | application/octet-stream | 8.5 KB |
| v2_0004-reloption-parallel_dml-test-and-doc.patch | application/octet-stream | 6.4 KB |
| v2_0001-guc-option-enable_parallel_dml-src.patch | application/octet-stream | 3.5 KB |
| v2_0002-guc-option-enable_parallel_dml-doc-and-test.patch | application/octet-stream | 4.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2021-02-01 05:28:45 | Re: [PATCH] Add extra statistics to explain for Nested Loop |
| Previous Message | Amit Kapila | 2021-02-01 04:44:29 | Re: Single transaction in the tablesync worker? |