Re: [PATCH] pglister: auth_receive: Indicate when PGAUTH_KEY is invalid instead of crashing

From: Célestin Matte <celestin(dot)matte(at)cmatte(dot)me>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-www(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] pglister: auth_receive: Indicate when PGAUTH_KEY is invalid instead of crashing
Date: 2023-07-13 13:03:14
Message-ID: 09852d51-5d16-7177-3a56-e83caee21c46@cmatte.me
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

> It seems a patch like this was already merged into the upstream of
> this, and got deployed into pgarchives & pglister when I synced those
> up a couple of weeks ago. Sorry about the lateness of that one. Does
> the current version of the code work for what you were looking for?

This is the same as what my patch does, indeed

> It might also be worth considering also checking explicitly for the
> format of PGAUTH_KEY on startup. Something like the attached maybe?
> (against pgweb which is the master of this file) What do you think?

LGTM

--
Célestin Matte

In response to

Responses

Browse pgsql-www by date

  From Date Subject
Next Message Célestin Matte 2023-07-13 13:36:20 Re: pgarchives: Bug report + Patches: loader can't handle message in multiple lists
Previous Message Bernd Helmle 2023-07-13 11:44:39 Re: Wiki editor request